Auto dataset concatenation prototype#128
Merged
jlamypoirier merged 4 commits intomainfrom Jan 27, 2025
Merged
Conversation
tscholak
reviewed
Jan 25, 2025
fast_llm/data/dataset/gpt/config.py
Outdated
Comment on lines
+169
to
+171
| class GPTComposedDatasetConfig(GPTIndexedDatasetConfig): | ||
| _abstract: typing.ClassVar[bool] = False | ||
| type_: typing.ClassVar[str | None] = "composed" |
Collaborator
There was a problem hiding this comment.
Suggested change
| class GPTComposedDatasetConfig(GPTIndexedDatasetConfig): | |
| _abstract: typing.ClassVar[bool] = False | |
| type_: typing.ClassVar[str | None] = "composed" | |
| class GPTConcatenatedMemmapConfig(GPTIndexedDatasetConfig): | |
| _abstract: typing.ClassVar[bool] = False | |
| type_: typing.ClassVar[str | None] = "concatenated_memmap" |
for your convenience, so that we can merge this easily.
tscholak
reviewed
Jan 25, 2025
tests/test_dataset.py
Outdated
| from fast_llm.data.data.gpt.data import GPTData | ||
| from fast_llm.data.dataset.gpt.config import ( | ||
| GPTBlendedDatasetConfig, | ||
| GPTComposedDatasetConfig, |
Collaborator
There was a problem hiding this comment.
Suggested change
| GPTComposedDatasetConfig, | |
| GPTConcatenatedMemmapConfig, |
tscholak
reviewed
Jan 25, 2025
tests/test_dataset.py
Outdated
Comment on lines
+408
to
+409
| {"type": "composed", "path": _DATASET_PREFIX_MIX_COMPOSED}, | ||
| GPTComposedDatasetConfig, |
Collaborator
There was a problem hiding this comment.
Suggested change
| {"type": "composed", "path": _DATASET_PREFIX_MIX_COMPOSED}, | |
| GPTComposedDatasetConfig, | |
| {"type": "concatenated_memmap", "path": _DATASET_PREFIX_MIX_CONCATENATED_MEMMAP}, | |
| GPTConcatenatedMemmapConfig, |
tscholak
reviewed
Jan 25, 2025
tests/test_dataset.py
Outdated
|
|
||
| DATASET_PREFIX_MIX_1 = DATASET_PREFIX.with_name("blended_mix_1") | ||
| _DATASET_PREFIX_MIX_1 = DATASET_PREFIX.with_name("blended_mix_1") | ||
| _DATASET_PREFIX_MIX_COMPOSED = DATASET_CACHE / "composed" |
Collaborator
There was a problem hiding this comment.
Suggested change
| _DATASET_PREFIX_MIX_COMPOSED = DATASET_CACHE / "composed" | |
| _DATASET_PREFIX_MIX_CONCATENATED_MEMMAP = DATASET_CACHE / "concatenated_memmap" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ Description
Fixes: #120. A basic approach, to be refined in #123 .
🔍 Type of change
Select all that apply: